Skip to content

Update Branches to Noetic - #541

Merged
AndyZe merged 3 commits into
moveit:masterfrom
DLu:noetic_updates
Oct 8, 2020
Merged

Update Branches to Noetic#541
AndyZe merged 3 commits into
moveit:masterfrom
DLu:noetic_updates

Conversation

@DLu

@DLu DLu commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Description

This updates many of the references to melodic (and sometimes indigo) to refer to noetic.

This does not include references to noetic entities that do not exist yet, like for moveit_graps and panda_moveit_config

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

AndyZe
AndyZe approved these changes Oct 8, 2020
View reviewed changes

@AndyZe AndyZe left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's get CI passing - may need to revert some of the link changes

Comment thread doc/tests/tests_tutorial.rst Outdated
@DLu

DLu commented Oct 8, 2020

Copy link
Copy Markdown
Contributor Author

The CI is not passing because changing the conf updated some of the internal links, mainly for [https://github.com/moveit/panda_moveit_config/issues/72](Panda Moveit Config). Should I

  • Revert the conf changes
  • Manually edit the conf to point at different panda branch
  • Wait until the branch exists to merge this

@AndyZe

AndyZe commented Oct 8, 2020

Copy link
Copy Markdown
Member

I lean toward manually editing the conf with a TODO, but all 3 options sound OK.

The format we usually use for TODOs is: TODO(andyz): use ros_distro when that branch is available again

@AndyZe

AndyZe commented Oct 8, 2020

Copy link
Copy Markdown
Member

thanks!

@AndyZe
AndyZe merged commit 40bd382 into moveit:master Oct 8, 2020
@DLu
DLu deleted the noetic_updates branch October 8, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyZe AndyZe AndyZe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DLu @AndyZe